Check pyrightconfig stricter exclude list order #15243
Merged
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
Jan 15, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, two optional comments below.
tests/check_typeshed_structure.py
Outdated
Comment on lines
181
to
185
| # Remove full-line // comments only | ||
| # (Can not remove inline comments) | ||
| text = re.sub(r"(?m)^\s*//.*\n?", "", text) | ||
| # Remove trailing commas before } or ] | ||
| text = re.sub(r",\s*([}\]])", r"\1", text) |
Collaborator
There was a problem hiding this comment.
We could extract this to a new (incomplete) utility function json5_to_json. Might come in useful in the future.
srittau
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was proposed in #8774